Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port the MultiSelect API from FW8 #3914

Merged
merged 3 commits into from
Apr 18, 2018
Merged

Conversation

gilberto-torrezan
Copy link
Contributor

@gilberto-torrezan gilberto-torrezan commented Apr 17, 2018

This change is Reviewable

@ZheSun88
Copy link
Contributor

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 8 unresolved discussions.


a discussion (no related file):
Do you want to remove all the redundant public? not a blocker


flow-data/src/main/java/com/vaadin/flow/data/selection/MultiSelect.java, line 151 at r1 (raw file):

    }

    @Override

just curious, in the FW8 file, there are no these two overrides. how do they deal with it? why do we need it?


Comments from Reviewable

@ZheSun88
Copy link
Contributor

Review status: all files reviewed at latest revision, 8 unresolved discussions.


flow-data/src/main/java/com/vaadin/flow/data/selection/MultiSelect.java, line 151 at r1 (raw file):

Previously, ZheSun88 (Sun Zhe) wrote…

just curious, in the FW8 file, there are no these two overrides. how do they deal with it? why do we need it?

oh, I see, those changes come from Grid. As Grid is the only component to support MultiSelection so far, it is okay.


Comments from Reviewable

@gilberto-torrezan
Copy link
Contributor Author

Review status: 0 of 1 files reviewed at latest revision, 8 unresolved discussions.


a discussion (no related file):

Previously, ZheSun88 (Sun Zhe) wrote…

Do you want to remove all the redundant public? not a blocker

Done


Comments from Reviewable

@ZheSun88
Copy link
Contributor

:lgtm:


Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 8 unresolved discussions.


Comments from Reviewable

@ZheSun88 ZheSun88 merged commit 5012cf1 into master Apr 18, 2018
@ZheSun88 ZheSun88 deleted the gilberto/115_multi_select branch April 18, 2018 07:09
@SomeoneToIgnore SomeoneToIgnore added this to the 1.0.0.beta8 milestone Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants