Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eagerly update bean if initial value is changed #4138

Merged
merged 1 commit into from
May 22, 2018

Conversation

Legioth
Copy link
Member

@Legioth Legioth commented May 18, 2018

Related to vaadin/framework#9000


This change is Reviewable

@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 6 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR Binder.java#L713: Make "field" transient or serializable. rule
  2. MAJOR Binder.java#L945: Make "field" transient or serializable. rule
  3. MAJOR Binder.java#L1270: Make "incompleteMemberFieldBindings" transient or serializable. rule
  4. MAJOR Binder.java#L1276: Make "incompleteBindings" transient or serializable. rule
  5. MAJOR Binder.java#L1280: Make "initialConverters" transient or serializable. rule
  6. MINOR Binder.java#L971: Replace this lambda with a method reference. rule

@caalador
Copy link
Contributor

:lgtm:


Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@caalador caalador merged commit bbaeba9 into master May 22, 2018
@caalador caalador deleted the writeBackInitialValue branch May 22, 2018 06:34
@pekam pekam added this to the 1.0.0.beta12 milestone May 24, 2018
TatuLund added a commit to vaadin/framework that referenced this pull request Oct 24, 2019
Addresses: #9000

Addresses:  #11109

These changes are adopted from vaadin/flow#4138 and vaadin/flow#6757
Ansku pushed a commit to vaadin/framework that referenced this pull request Nov 13, 2019
* Cherry picks of Binder fixes in Flow

Addresses: #9000

Addresses:  #11109

These changes are adopted from vaadin/flow#4138 and vaadin/flow#6757
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants