Only mark as required if empty value would fail validation #4139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaadin-bot
reviewed
May 18, 2018
| @@ -748,6 +748,10 @@ protected BindingBuilderImpl(Binder<BEAN> binder, | |||
| this.statusHandler = statusHandler; | |||
| } | |||
|
|
|||
| Converter<FIELDVALUE, ?> getConverterValidatorChain() { | |||
There was a problem hiding this comment.
Also fixes #2261 Related to vaadin/framework#9000
|
SonarQube analysis reported 7 issues
Watch the comments in this conversation to review them. 6 extra issuesNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
|
Reviewed 4 of 5 files at r1, 1 of 1 files at r2. Comments from Reviewable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes #2261
Related to vaadin/framework#9000
This change is