-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid using java.util collections in GWT code #4166
Conversation
lazyDependencies.putAll(extractLazyDependenciesAndLoadOthers( | ||
entry.getKey(), entry.getValue())); | ||
} | ||
clientDependencies.forEach((dependencies, mode) -> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1. flow-client/src/main/java/com/vaadin/client/DependencyLoader.java, line 163 at r1 (raw file):
Is it a replacement for Comments from Reviewable |
Review status: all files reviewed at latest revision, 2 unresolved discussions. flow-client/src/main/java/com/vaadin/client/DependencyLoader.java, line 163 at r1 (raw file): Previously, denis-anisimov (Denis) wrote…
Comments from Reviewable |
Review status: all files reviewed at latest revision, 1 unresolved discussion. Comments from Reviewable |
This reduces the gzipped size of the client engine by around 10% from 48864 to 44808 bytes.
Reviewed 5 of 5 files at r1. Comments from Reviewable |
This reduces the gzipped size of the client engine by around 10% from
48864 to 44808 bytes.
This change is