Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing null check to Binding #4196

Merged
merged 1 commit into from
May 30, 2018
Merged

Add missing null check to Binding #4196

merged 1 commit into from
May 30, 2018

Conversation

pekam
Copy link
Contributor

@pekam pekam commented May 29, 2018

Ported change from vaadin/framework#10726


This change is Reviewable

@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 2 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR Binder.java#L749: Remove usage of generic wildcard type. rule
  2. MINOR Binder.java#L975: Replace this lambda with a method reference. rule

@denis-anisimov
Copy link
Contributor

:lgtm:


Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@denis-anisimov denis-anisimov merged commit 00a803f into master May 30, 2018
@denis-anisimov denis-anisimov deleted the port-10726 branch May 30, 2018 05:25
@denis-anisimov denis-anisimov added this to the 1.0.0.rc1 milestone May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants