Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always return a fresh copy of BeanPropertySet from cache #4204

Merged
merged 1 commit into from
May 30, 2018

Conversation

ZheSun88
Copy link
Contributor

@ZheSun88 ZheSun88 commented May 30, 2018

Port Change from framework, original PR vaadin/framework#10635


This change is Reviewable

@denis-anisimov
Copy link
Contributor

Review status: all files reviewed at latest revision, all discussions resolved.


a discussion (no related file):
PropertyRetrospectionTest is not ported ?


Comments from Reviewable

@ZheSun88
Copy link
Contributor Author

Review status: all files reviewed at latest revision, 1 unresolved discussion.


a discussion (no related file):

Previously, denis-anisimov (Denis) wrote…

PropertyRetrospectionTest is not ported ?

you are too fast, denis. PropertyRetrospectionTest have been ported to grid repo, because it is using the component in the test. vaadin/vaadin-grid-flow#215


Comments from Reviewable

@denis-anisimov
Copy link
Contributor

:lgtm:


Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@ZheSun88 ZheSun88 merged commit e4799e7 into master May 30, 2018
@ZheSun88 ZheSun88 deleted the port-change-10635 branch May 30, 2018 08:19
@ZheSun88 ZheSun88 added this to the 1.0.0.rc2 milestone Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants