Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ValueChangeListener order changes with Binder #4205

Merged
merged 1 commit into from
May 30, 2018
Merged

Conversation

ZheSun88
Copy link
Contributor

@ZheSun88 ZheSun88 commented May 30, 2018

Port Change from framework 8.4.0.alpha1
Original PR is vaadin/framework#10745


This change is Reviewable

Port Change from framework 8.4.0.alpha1
Original PR is vaadin/framework#10745
@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 1 issue

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR Binder.java#L749: Remove usage of generic wildcard type. rule

@pekam
Copy link
Contributor

pekam commented May 30, 2018

:lgtm:


Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@pekam pekam merged commit e8c51d3 into master May 30, 2018
@pekam pekam deleted the port-change-10745 branch May 30, 2018 08:38
@ZheSun88 ZheSun88 added this to the 1.0.0.rc2 milestone Jun 6, 2018
pleku pushed a commit that referenced this pull request Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants