-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect frontend directory locations dynamically based on project #4237
Conversation
Review status: 0 of 2 files reviewed at latest revision, all discussions resolved. flow-maven-plugin/src/main/java/com/vaadin/flow/plugin/maven/CopyProductionFilesMojo.java, line 64 at r1 (raw file):
Break out arrays.asList to have the for more readable. flow-maven-plugin/src/main/java/com/vaadin/flow/plugin/maven/PackageForProductionMojo.java, line 117 at r1 (raw file):
drop "classes" and use Comments from Reviewable |
Review status: 0 of 2 files reviewed at latest revision, 2 unresolved discussions. flow-maven-plugin/src/main/java/com/vaadin/flow/plugin/maven/CopyProductionFilesMojo.java, line 68 at r1 (raw file):
missing Comments from Reviewable |
Review status: all files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
@ripla, we need probably some similar logic to Designer, so that it creates design files to src/main/resources/META-INF/frontend for spring boot projects. Shall I create an issue for that? |
If source and target directories are not explicitly defined, those are now detected dynamically based on the project type, so that spring boot projects don't need special settings.
This change is