Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send 404 for non-existing frontend resources #4258

Merged
merged 1 commit into from
Jun 22, 2018
Merged

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Jun 11, 2018

This change is Reviewable

@denis-anisimov
Copy link
Contributor

Reviewed 1 of 1 files at r1.
Review status: 1 unresolved discussion, 0 of 1 LGTMs obtained


a discussion (no related file):
Any test? (unit test may be)


Comments from Reviewable

@Artur-
Copy link
Member Author

Artur- commented Jun 18, 2018

Review status: 1 unresolved discussion, 0 of 1 LGTMs obtained


a discussion (no related file):

Previously, denis-anisimov (Denis) wrote…

Any test? (unit test may be)

Done.


Comments from Reviewable

@denis-anisimov
Copy link
Contributor

Reviewed 3 of 3 files at r2.
Review status: 1 unresolved discussion, 0 of 1 LGTMs obtained


a discussion (no related file):
The PR is fine but we don't merge anything until release.


Comments from Reviewable

@denis-anisimov
Copy link
Contributor

:lgtm:


Review status: all discussions resolved, 0 of 1 LGTMs obtained, and 1 stale


Comments from Reviewable

@denis-anisimov denis-anisimov merged commit fb5595a into master Jun 22, 2018
@denis-anisimov denis-anisimov deleted the 404-for-frontend branch June 22, 2018 15:00
gilberto-torrezan pushed a commit that referenced this pull request Jul 11, 2018
* Send 404 for non-existing frontend resources
gilberto-torrezan pushed a commit that referenced this pull request Jul 11, 2018
* Send 404 for non-existing frontend resources
@gilberto-torrezan gilberto-torrezan added this to the 1.0.1 milestone Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants