Make it possible to use subtypes of JsonValue in ASPropertyField #4488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaadin-bot
reviewed
Aug 7, 2018
| }; | ||
| ElementSetter<P> setter = (element, property, value) -> element | ||
| .setPropertyJson(property, value); | ||
| return new TypeHandler<P>(setter, getter, null); |
There was a problem hiding this comment.
vaadin-bot
reviewed
Aug 7, 2018
| .map(Class::getName) | ||
| .collect(Collectors.joining(", "))); | ||
| } | ||
| TypeHandler<P> typeHandler = findHandler(elementPropertyType); | ||
|
|
||
| Element element = getElement(); |
There was a problem hiding this comment.
|
SonarQube analysis reported 2 issues
Watch the comments in this conversation to review them. |
gilberto-torrezan
approved these changes
Aug 13, 2018
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status: 2 unresolved discussions, 0 of 1 LGTMs obtained, and 1 stale
ZheSun88
approved these changes
Aug 13, 2018
There was a problem hiding this comment.
Dismissed @vaadin-bot from 2 discussions.
Reviewable status:complete! all discussions resolved, 1 of 1 LGTMs obtained
denis-anisimov
pushed a commit
that referenced
this pull request
Aug 13, 2018
ZheSun88
pushed a commit
that referenced
this pull request
Aug 13, 2018
This was referenced Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4463
This change is