Add Element.executeJavaScript #4539
Conversation
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1.
Reviewable status: all discussions resolved, 0 of 1 LGTMs obtained
flow-server/src/main/java/com/vaadin/flow/dom/Element.java, line 1474 at r1 (raw file):
public void executeJavaScript(
public ?
Without any javadocs?
There was a problem hiding this comment.
Reviewable status: all discussions resolved, 0 of 1 LGTMs obtained
flow-server/src/main/java/com/vaadin/flow/dom/Element.java, line 1474 at r1 (raw file):
Previously, denis-anisimov (Denis) wrote…
public void executeJavaScript(
public?
Without any javadocs?
Also it should be added to an exception list as ElementTest.publicElementMethodsShouldReturnElement test fails.
Legioth
force-pushed
the
element_executeJavaScript
branch
3 times, most recently
from
89f0682
to
695d459
Compare
There was a problem hiding this comment.
2 JS tests have failed in the build.
- TimingInfoReporedViwe has a
(TypeError) : (intermediate value).apply(...and aScript error: (:0) - JsApiGetByIdView has a
(TypeError) : Cannot read property 'getByNodeId' of undefined
Reviewable status: all discussions resolved, 0 of 1 LGTMs obtained
Legioth
force-pushed
the
element_executeJavaScript
branch
from
695d459
to
470cdaa
Compare
| @@ -1338,12 +1341,13 @@ public Registration addAttachListener( | |||
| // This explicit class instantiation is the workaround | |||
| // which fixes a JVM optimization+serialization bug. | |||
| // Do not convert to lambda | |||
| // Detected under Win7_64 /JDK 1.8.0_152, 1.8.0_172 | |||
| // Detected under Win7_64 /JDK 1.8.0_152, 1.8.0_172 | |||
| // see ElementAttributeMap#deferRegistration | |||
| new Command() { | |||
There was a problem hiding this comment.
| @@ -1370,12 +1374,13 @@ public Registration addDetachListener( | |||
| // This explicit class instantiation is the workaround | |||
| // which fixes a JVM optimization+serialization bug. | |||
| // Do not convert to lambda | |||
| // Detected under Win7_64 /JDK 1.8.0_152, 1.8.0_172 | |||
| // Detected under Win7_64 /JDK 1.8.0_152, 1.8.0_172 | |||
| // see ElementAttributeMap#deferRegistration | |||
| new Command() { | |||
There was a problem hiding this comment.
|
SonarQube analysis reported 4 issues
Watch the comments in this conversation to review them. 2 extra issuesNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
There was a problem hiding this comment.
Reviewed 5 of 8 files at r1, 4 of 5 files at r2.
Dismissed @vaadin-bot from 2 discussions.
Reviewable status: all discussions resolved, 0 of 1 LGTMs obtained, and 1 stale
Fixes #4538
This change is