Precompress production bundles #4571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By precompressing the production bundle and related files, the download size is significantly reduced even in cases where the application server isn't configured to compress static resources on-the-fly. In addition to gzip, precompression is also done with Brotli for further savings when applicable. The bundle size for Beverage Buddy is reduced from 729 KB to 191 KB with gzip and 153 KB with Brotli. With the Fast 3G preset in Chrome, application load time with an empty cache is reduced from around 5.4 seconds to 2.4. Note that Brotli files will only be automatically used after #4556 has also been merged. Fixes #3765
SomeoneToIgnore
approved these changes
Aug 31, 2018
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status: all discussions resolved, 0 of 1 LGTMs obtained, and 1 stale
flow-maven-plugin/src/main/resources/gulpfile.js, line 126 at r1 (raw file):
.pipe(gzip()); const brotliStream = gulp.src(`${configurationTargetDirectory}/**/*.{html,css,js}`) .pipe(brotli.compress());
We might be compressing it with different compression level in comparison to the one in #4556
bit it's not really related, so might be fine.
|
flow-maven-plugin/src/main/resources/gulpfile.js, line 126 at r1 (raw file): Previously, SomeoneToIgnore (Kirill Bulatov) wrote…
For the record, I have manually verified that both libraries use the highest compression level by default. |
This was referenced Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By precompressing the production bundle and related files, the download
size is significantly reduced even in cases where the application server
isn't configured to compress static resources on-the-fly. In addition to
gzip, precompression is also done with Brotli for further savings when
applicable.
The bundle size for Beverage Buddy is reduced from 729 KB to 191 KB with
gzip and 153 KB with Brotli. With the Fast 3G preset in Chrome,
application load time with an empty cache is reduced from around 5.4
seconds to 2.4.
Note that Brotli files will only be automatically used after #4556 has
also been merged.
Fixes #3765
This change is