Override ordering for bundle dependency filters

[Legioth]

Backported variant of #4878. This approach avoids API changes, but
increases complexity instead of reducing it.

---

This change is 

[denis-anisimov]

Reviewed 1 of 1 files at r1.
Reviewable status: 1 unresolved discussion, 0 of 1 LGTMs obtained

---

flow-server/src/main/java/com/vaadin/flow/server/VaadinService.java, line 278 at r1 (raw file):

                .sorted(Comparator.comparingInt(
                        filter -> filter instanceof BundleDependencyFilter ? 1
                                : 0))

This logic could be tested.

[Legioth]

---

flow-server/src/main/java/com/vaadin/flow/server/VaadinService.java, line 278 at r1 (raw file):

Previously, denis-anisimov (Denis) wrote…

                .sorted(Comparator.comparingInt(
                        filter -> filter instanceof BundleDependencyFilter ? 1
                                : 0))

This logic could be tested.

Please suggest any sensible way of testing this. For reference, the original implementation that was included in master didn't have any tests for the reasons described in #4878 (comment).

[denis-anisimov]

Reviewable status: 1 unresolved discussion, 0 of 1 LGTMs obtained

---

flow-server/src/main/java/com/vaadin/flow/server/VaadinService.java, line 278 at r1 (raw file):

Previously, Legioth (Leif Åstrand) wrote…

Please suggest any sensible way of testing this. For reference, the original implementation that was included in master didn't have any tests for the reasons described in #4878 (comment).

I'm not sure that I've not missed something but it looks like this should work:

• Extend VaadinService.
• Override either createInstantiator().
• Return you own Instantiator mock.
• Mock/override getDependencyFilters method.
• Check that getDependencyFilters() returns the BundleDependencyFilter instances in the end of Iterable.

Looks like everything is doable.

[Legioth]

Reviewable status: 1 unresolved discussion, 0 of 1 LGTMs obtained

---

flow-server/src/main/java/com/vaadin/flow/server/VaadinService.java, line 278 at r1 (raw file):

Previously, denis-anisimov (Denis) wrote…

I'm not sure that I've not missed something but it looks like this should work:

• Extend VaadinService.
• Override either createInstantiator().
• Return you own Instantiator mock.
• Mock/override getDependencyFilters method.
• Check that getDependencyFilters() returns the BundleDependencyFilter instances in the end of Iterable.

Looks like everything is doable.

Done.

[vaadin-bot]

SonarQube analysis reported 6 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

1. VaadinService.java#L2101: First sentence of Javadoc is incomplete (period is missing) or not present.
2. VaadinService.java#L2135: First sentence of Javadoc is incomplete (period is missing) or not present.
3. VaadinService.java#L2147: First sentence of Javadoc is incomplete (period is missing) or not present.
4. VaadinService.java#L2159: First sentence of Javadoc is incomplete (period is missing) or not present.
5. VaadinService.java#L573: This call to "add()" may be a performance hot spot if the collection is large.
6. VaadinService.java#L574: This call to "remove()" may be a performance hot spot if the collection is large.

[denis-anisimov]

Reviewed 1 of 1 files at r2.
Reviewable status: 1 unresolved discussion, 1 of 1 LGTMs obtained

[denis-anisimov]

Reviewable status: complete! all discussions resolved, 1 of 1 LGTMs obtained