Add OSGi to usage statistics (#4895) #4899
Conversation
The OSGi detection seems impossible to fake from a test that doesn't have OSGi framework on the classpath, so no test for this.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all discussions resolved, 1 of 1 LGTMs obtained
| @@ -263,10 +265,30 @@ private ServletContext createOSGiServletContext() { | |||
| private static boolean isInOSGi() { | |||
| try { | |||
| Class.forName("org.osgi.framework.FrameworkUtil"); | |||
|
|
|||
| UsageStatistics.markAsUsed("flow/osgi", getOSGiVersion()); | |||
|
|
|||
| return true; | |||
| } catch (ClassNotFoundException exception) { | |||
There was a problem hiding this comment.
| try { | ||
| Bundle osgiBundle = org.osgi.framework.FrameworkUtil.getBundle(Bundle.class); | ||
| return osgiBundle.getVersion().toString(); | ||
| } catch (Throwable throwable) { |
There was a problem hiding this comment.
|
SonarQube analysis reported 5 issues
Watch the comments in this conversation to review them. 2 extra issuesNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
There was a problem hiding this comment.
Dismissed @vaadin-bot from 2 discussions.
Reviewable status:
There was a problem hiding this comment.
Reviewable status:
The OSGi detection seems impossible to fake from a test that doesn't
have OSGi framework on the classpath, so no test for this.
This change is