Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page.open() / Page.setLocation() functionality added #5128

Closed
wants to merge 1 commit into from
Closed

Page.open() / Page.setLocation() functionality added #5128

wants to merge 1 commit into from

Conversation

Lozadaa
Copy link

@Lozadaa Lozadaa commented Feb 25, 2019

fix to issue #4869


This change is Reviewable

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Richard Lozada seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Richard Lozada seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Lozadaa Lozadaa closed this Feb 25, 2019
/**
* Open window in browser.
*/
public void open(String url) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CRITICAL Document the parameter(s): url rule

* Change the current page in the browser.
*/
public void setLocation(String url) {
executeJavaScript("window.location.replace("+url+");");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BLOCKER File contains tab characters (this is the first instance). rule

@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 5 issues

  • BLOCKER 1 blocker
  • CRITICAL 1 critical
  • MAJOR 3 major

Watch the comments in this conversation to review them.

3 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR Page.java#L74: Call "Optional#isPresent()" before accessing the value. rule
  2. MAJOR Page.java#L88: Call "Optional#isPresent()" before accessing the value. rule
  3. MAJOR Page.java#L422: Define and throw a dedicated exception instead of using a generic one. rule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants