Download a supported version of Node and make production build work with new Node versions #5891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denis-anisimov
previously approved these changes
Jun 13, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all discussions resolved, 1 of 1 LGTMs obtained
|
Blocked by #5892 |
Artur-
force-pushed
the
dl-supported-node
branch
from
21920fb
to
375aaff
Compare
Artur-
changed the title
|
Pardon me, but can this both fix and be blocked by #5892? Is there a typo somewhere? |
|
It was updated to fix the issue alao instead of being blocked by it |
caalador
approved these changes
Jun 14, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5892, #4888, #5028
This change is