Do clean up in case the shrink-wrap versions are different #6001
Conversation
project-bot
bot
added this to Review in progress
in OLD Vaadin Flow ongoing work (Vaadin 10+)
| } | ||
|
|
||
| private String getShrinkWrapVersion(JsonObject packageJson) | ||
| throws IOException { |
There was a problem hiding this comment.
|
SonarQube analysis reported 2 issues
Watch the comments in this conversation to review them. |
| private void cleanUp() throws IOException { | ||
| File packageLock = getPackageLock(); | ||
| if (packageLock.exists()) { | ||
| if (!packageLock.delete()) { |
There was a problem hiding this comment.
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status: 3 unresolved discussions, 0 of 1 LGTMs obtained (waiting on @denis-anisimov)
flow-server/src/main/java/com/vaadin/flow/server/frontend/TaskUpdatePackages.java, line 125 at r1 (raw file):
} private void ensureReleaseVersion(JsonObject dependencies)
I am unable to build flow, but the code looks good.
The only addition I'd like is a comment on this function explaining what it does and which files are potentially affected.
There was a problem hiding this comment.
Reviewable status: 3 unresolved discussions, 0 of 1 LGTMs obtained (waiting on @denis-anisimov and @ujoni)
flow-server/src/main/java/com/vaadin/flow/server/frontend/TaskUpdatePackages.java, line 125 at r1 (raw file):
Previously, ujoni (Joni) wrote…
I am unable to build flow, but the code looks good.
The only addition I'd like is a comment on this function explaining what it does and which files are potentially affected.
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status: 2 unresolved discussions, 1 of 1 LGTMs obtained (waiting on @denis-anisimov)
There was a problem hiding this comment.
Dismissed @vaadin-bot from 2 discussions.
Reviewable status:complete! all discussions resolved, 1 of 1 LGTMs obtained
Fixes #5967
This change is