New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CCDM: implement Flow.start() API #6194
Conversation
9d783dc
to
8e86955
Compare
8e86955
to
b796e69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 10 of 10 files at r1.
Reviewable status: 2 unresolved discussions, 0 of 1 LGTMs obtained (waiting on @manolo and @qtdzz)
flow-client/src/main/resources/META-INF/resources/frontend/Flow.ts, line 60 at r1 (raw file):
} async __initFlowClient(clientMod: any): Promise<void> {
How about using a private
modifier from TypeScript instead of __memberName
prefixes?
flow-client/src/main/resources/META-INF/resources/frontend/Flow.ts, line 85 at r1 (raw file):
resolve(JSON.parse(httpRequest.responseText)); } else { reject(httpRequest);
Nit: typically a Promise rejection is expected to give an error object, same as with throw
. Here we give a request instead.
Would be probably nicer to have some error object here. The caller method will carry this rejection outside, I think.
Not blocking for now, fine by me to improve this later.
ced4fa9
to
d21cd88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@platosha had to remove FF because failed in TC
Reviewable status: 1 unresolved discussion, 0 of 1 LGTMs obtained (waiting on @platosha and @qtdzz)
flow-client/src/main/resources/META-INF/resources/frontend/Flow.ts, line 60 at r1 (raw file):
Previously, platosha (Anton Platonov) wrote…
How about using a
private
modifier from TypeScript instead of__memberName
prefixes?
Done.
flow-client/src/main/resources/META-INF/resources/frontend/Flow.ts, line 85 at r1 (raw file):
Previously, platosha (Anton Platonov) wrote…
Nit: typically a Promise rejection is expected to give an error object, same as with
throw
. Here we give a request instead.Would be probably nicer to have some error object here. The caller method will carry this rejection outside, I think.
Not blocking for now, fine by me to improve this later.
Done. Also added a test for this code.
d21cd88
to
35808c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r2.
Reviewable status: complete! all discussions resolved, 1 of 1 LGTMs obtained (waiting on @qtdzz)
This fixes #6133
FlowBootstrap.js
file that is distributed inflow-client.jar
. It is based inBootstrapHandler.js
but with small modifications to be an ES module.FlowClient.js
to be distributed in the client jar file. It needs to be wrapped in a function so as it can be lazily executed.FlowBootstrap.js
andFlowClient.js
files so as they can be used from typescript.Flow.start()
method with the following stepsJavaScriptBoostrapHandler
in order to get create sessionand get the application configuration
FlowBootstrap.js
chunk and initialize it with the response from the previous stepFlowClient.js
chunk and run it.This change is