Update enabled status for virtual children of Element without Component #6315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
project-bot
bot
added this to External Reviews
in OLD Vaadin Flow ongoing work (Vaadin 10+)
denis-anisimov
pushed a commit
to vaadin/vaadin-grid-flow
that referenced
this pull request
Aug 23, 2019
|
IT tests is provided here: vaadin/vaadin-grid-flow#750 |
vaadin-bot
reviewed
Aug 23, 2019
| return checkParentChainState(parentComponent); | ||
| Element parent = element.getParent(); | ||
| if (parent != null) { | ||
| if (isAttachedToParent(element, parent)) { |
There was a problem hiding this comment.
|
SonarQube analysis reported 1 issue
Watch the comments in this conversation to review them. |
ujoni
approved these changes
Aug 27, 2019
There was a problem hiding this comment.
Can you merge this PR so, that the merge commit contains a short explanation of how this fixes the issue? It is not immediately obvious and might be nice to have a record.
Reviewed 1 of 2 files at r1.
Reviewable status: 1 unresolved discussion, 1 of 1 LGTMs obtained (waiting on @denis-anisimov)
OLD Vaadin Flow ongoing work (Vaadin 10+)
automation
moved this from External Reviews
to Reviewer approved
Aug 27, 2019
ujoni
approved these changes
Aug 27, 2019
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1.
Reviewable status: 1 unresolved discussion, 1 of 1 LGTMs obtained (waiting on @denis-anisimov)
denis-anisimov
commented
Aug 27, 2019
There was a problem hiding this comment.
Dismissed @vaadin-bot from a discussion.
Reviewable status:complete! all discussions resolved, 1 of 1 LGTMs obtained
OLD Vaadin Flow ongoing work (Vaadin 10+)
automation
moved this from Reviewer approved
to Done - pending release
Aug 27, 2019
denis-anisimov
pushed a commit
that referenced
this pull request
Aug 27, 2019
…nt (#6315) ComponentUtil::onComponentAttach/ComponentUtil::onComponentDetach should use Element API parent to decide whether to call Component::onEnabledStateChanged. That allows to use correct parent in case there is no Component mapped to Element. Fixes vaadin/vaadin-grid-flow#687
denis-anisimov
pushed a commit
that referenced
this pull request
Aug 27, 2019
(#6315) ComponentUtil::onComponentAttach/ComponentUtil::onComponentDetach should use Element API parent to decide whether to call Component::onEnabledStateChanged. That allows to use correct parent in case there is no Component mapped to Element. Fixes vaadin/vaadin-grid-flow#687 # Conflicts: # flow-server/src/test/java/com/vaadin/flow/component/ComponentTest.java
caalador
moved this from Done - pending release
to External Reviews
in OLD Vaadin Flow ongoing work (Vaadin 10+)
denis-anisimov
pushed a commit
that referenced
this pull request
Aug 27, 2019
(#6315) ComponentUtil::onComponentAttach/ComponentUtil::onComponentDetach should use Element API parent to decide whether to call Component::onEnabledStateChanged. That allows to use correct parent in case there is no Component mapped to Element.
caalador
moved this from External Reviews
to Reviewer approved
in OLD Vaadin Flow ongoing work (Vaadin 10+)
caalador
moved this from Reviewer approved
to Done - pending release
in OLD Vaadin Flow ongoing work (Vaadin 10+)
ujoni
pushed a commit
that referenced
this pull request
Aug 27, 2019
…nt (#6315) ComponentUtil::onComponentAttach/ComponentUtil::onComponentDetach should use Element API parent to decide whether to call Component::onEnabledStateChanged. That allows to use correct parent in case there is no Component mapped to Element. Fixes vaadin/vaadin-grid-flow#687
ujoni
pushed a commit
that referenced
this pull request
Aug 27, 2019
(#6315) ComponentUtil::onComponentAttach/ComponentUtil::onComponentDetach should use Element API parent to decide whether to call Component::onEnabledStateChanged. That allows to use correct parent in case there is no Component mapped to Element. Fixes vaadin/vaadin-grid-flow#687 # Conflicts: # flow-server/src/test/java/com/vaadin/flow/component/ComponentTest.java
ujoni
pushed a commit
that referenced
this pull request
Aug 27, 2019
(#6315) ComponentUtil::onComponentAttach/ComponentUtil::onComponentDetach should use Element API parent to decide whether to call Component::onEnabledStateChanged. That allows to use correct parent in case there is no Component mapped to Element.
joheriks
pushed a commit
to vaadin/vaadin-grid-flow
that referenced
this pull request
Aug 28, 2019
* IT test for #687 and vaadin/flow#6315 PR.
joheriks
moved this from Done - pending release
to Released
in OLD Vaadin Flow ongoing work (Vaadin 10+)
This was referenced Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes vaadin/vaadin-grid-flow#687
This change is