Use VaadinServiceInitListener as an entry point for collecting endpoints #6326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
project-bot
bot
added this to External Reviews
in OLD Vaadin Flow ongoing work (Vaadin 10+)
Spring classes search by subtype is not able to find lambdas, so VaadinServiceInitListener is used as an entry point to search endpoints instead of UIInitListener as it's the only proper way to add a ui init listener Part of vaadin/spring#475
denis-anisimov
force-pushed
the
475-spring-ui-init-listener
branch
from
d390154
to
26da76e
Compare
ujoni
approved these changes
Aug 27, 2019
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1.
Reviewable status:complete! all discussions resolved, 1 of 1 LGTMs obtained
OLD Vaadin Flow ongoing work (Vaadin 10+)
automation
moved this from External Reviews
to Reviewer approved
Aug 27, 2019
OLD Vaadin Flow ongoing work (Vaadin 10+)
automation
moved this from Reviewer approved
to Done - pending release
Aug 27, 2019
denis-anisimov
pushed a commit
that referenced
this pull request
Aug 27, 2019
(#6326) Spring classes search by subtype is not able to find lambdas, so VaadinServiceInitListener is used as an entry point to search endpoints instead of UIInitListener as it's the only proper way to add a ui init listener
ujoni
pushed a commit
that referenced
this pull request
Aug 27, 2019
(#6326) Spring classes search by subtype is not able to find lambdas, so VaadinServiceInitListener is used as an entry point to search endpoints instead of UIInitListener as it's the only proper way to add a ui init listener
joheriks
pushed a commit
that referenced
this pull request
Aug 30, 2019
…nts (#6326) Spring classes search by subtype is not able to find lambdas, so VaadinServiceInitListener is used as an entry point to search endpoints instead of UIInitListener as it's the only proper way to add a ui init listener Part of vaadin/spring#475
joheriks
pushed a commit
that referenced
this pull request
Aug 30, 2019
…nts (#6326) Spring classes search by subtype is not able to find lambdas, so VaadinServiceInitListener is used as an entry point to search endpoints instead of UIInitListener as it's the only proper way to add a ui init listener Part of vaadin/spring#475
joheriks
pushed a commit
that referenced
this pull request
Aug 30, 2019
…nts (#6326) Spring classes search by subtype is not able to find lambdas, so VaadinServiceInitListener is used as an entry point to search endpoints instead of UIInitListener as it's the only proper way to add a ui init listener Part of vaadin/spring#475
joheriks
moved this from Done - pending release
to Released
in OLD Vaadin Flow ongoing work (Vaadin 10+)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spring classes search by subtype is not able to find lambdas, so
VaadinServiceInitListener is used as an entry point to search endpoints
instead of UIInitListener as it's the only proper way to add a ui init
listener
Part of vaadin/spring#475
This change is