Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start webpack IO thread as daemon #6515

Merged
merged 2 commits into from Sep 24, 2019
Merged

Start webpack IO thread as daemon #6515

merged 2 commits into from Sep 24, 2019

Conversation

Legioth
Copy link
Member

@Legioth Legioth commented Sep 20, 2019

Allows the Java process to terminate with Spring Boot 2.2

Related to vaadin/spring#491


This change is Reviewable

Allows the Java process to terminate with Spring Boot 2.2

Related to vaadin/spring#491
OLD Vaadin Flow ongoing work (Vaadin 10+) automation moved this from External Reviews to Reviewer approved Sep 20, 2019
Copy link
Contributor

@denis-anisimov denis-anisimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all discussions resolved, 1 of 1 LGTMs obtained

@Legioth Legioth changed the title Start webpack IO thread as deamon Start webpack IO thread as daemon Sep 20, 2019
@mehdi-vaadin mehdi-vaadin added this to the 2.0 Maintenance milestone Sep 20, 2019
@ujoni ujoni added the +0.0.1 label Sep 24, 2019
@mehdi-vaadin mehdi-vaadin merged commit 9236814 into master Sep 24, 2019
@mehdi-vaadin mehdi-vaadin deleted the deamonThread branch September 24, 2019 11:58
OLD Vaadin Flow ongoing work (Vaadin 10+) automation moved this from Reviewer approved to Done - pending release Sep 24, 2019
mehdi-vaadin pushed a commit that referenced this pull request Sep 24, 2019
Allows the Java process to terminate with Spring Boot 2.2

Related to vaadin/spring#491

(cherry picked from commit 9236814)
denis-anisimov pushed a commit that referenced this pull request Sep 25, 2019
Allows the Java process to terminate with Spring Boot 2.2

Related to vaadin/spring#491

(cherry picked from commit 9236814)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
OLD Vaadin Flow ongoing work (Vaadin ...
  
Done - pending release
Development

Successfully merging this pull request may close these issues.

None yet

5 participants