CCDM: deprecate server-side bootstrap related APIs #6517
Conversation
project-bot
bot
added this to External Reviews
in OLD Vaadin Flow ongoing work (Vaadin 10+)
qtdzz
force-pushed
the
tn/ccdm/deprecate-normal-bootstrap-api
branch
from
c80b2fa
to
cda6f23
Compare
| * @author Vaadin Ltd | ||
| * @since 1.0 | ||
| */ | ||
| @FunctionalInterface | ||
| @Deprecated | ||
| public interface BootstrapListener extends EventListener, Serializable { |
There was a problem hiding this comment.
| */ | ||
| @Deprecated | ||
| public void modifyBootstrapPage(BootstrapPageResponse response) { |
There was a problem hiding this comment.
| * @author Vaadin Ltd | ||
| * @since 1.0 | ||
| */ | ||
| @Deprecated | ||
| public class BootstrapPageResponse { |
There was a problem hiding this comment.
qtdzz
force-pushed
the
tn/ccdm/deprecate-normal-bootstrap-api
branch
from
cda6f23
to
6d298ec
Compare
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status: 3 unresolved discussions, 0 of 1 LGTMs obtained (waiting on @qtdzz)
a discussion (no related file):
BTW Not sure if this is relevant, but I find a few usages of BootstrapListener around, e. g., ServiceInitEvent#addBootstrapListener and so on. I guess this is kind of deprecated automatically, no need for annotation?
There was a problem hiding this comment.
Reviewable status: 3 unresolved discussions, 0 of 1 LGTMs obtained (waiting on @platosha and @qtdzz)
a discussion (no related file):
Previously, platosha (Anton Platonov) wrote…
BTW Not sure if this is relevant, but I find a few usages of
BootstrapListeneraround, e. g.,ServiceInitEvent#addBootstrapListenerand so on. I guess this is kind of deprecated automatically, no need for annotation?
Good catch! I actually missed them. I added the annotation and reword the message to be more descriptive.
| */ | ||
| @Deprecated | ||
| default Stream<BootstrapListener> getBootstrapListeners( |
There was a problem hiding this comment.
| */ | ||
| @Deprecated | ||
| public void addBootstrapListener(BootstrapListener bootstrapListener) { |
There was a problem hiding this comment.
| */ | ||
| @Deprecated | ||
| public Stream<BootstrapListener> getAddedBootstrapListeners() { |
There was a problem hiding this comment.
|
SonarQube analysis reported 10 issues
Watch the comments in this conversation to review them. 4 extra issuesNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
There was a problem hiding this comment.
Reviewed 5 of 5 files at r3.
Reviewable status: 6 unresolved discussions, 1 of 1 LGTMs obtained (waiting on @qtdzz)
There was a problem hiding this comment.
Dismissed @vaadin-bot from 6 discussions.
Reviewable status:complete! all discussions resolved, 1 of 1 LGTMs obtained
Fixes #6484
This PR deprecates
BootstrapListenerrelated APIs in favor ofClientIndexBootstrapListener.For other APIs which were used to modify/add content to the bootstrap page (e.g.
@PWA,PageConfigurator,@Inline,....) need to be considered separately.This change is