Terminate webpack dev server process only on connection error #6520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try to reconnect always on connection close. So the process is terminated only if there is a connection error (which happens if there is no network port available which is listen by Java process). Fixes vaadin/spring#494
project-bot
bot
added this to External Reviews
in OLD Vaadin Flow ongoing work (Vaadin 10+)
caalador
approved these changes
Sep 23, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all discussions resolved, 1 of 1 LGTMs obtained
OLD Vaadin Flow ongoing work (Vaadin 10+)
automation
moved this from External Reviews
to Reviewer approved
Sep 23, 2019
OLD Vaadin Flow ongoing work (Vaadin 10+)
automation
moved this from Reviewer approved
to Done - pending release
Sep 23, 2019
denis-anisimov
pushed a commit
that referenced
this pull request
Sep 23, 2019
Try to reconnect always on connection close. So the process is terminated only if there is a connection error (which happens if there is no network port available which is listen by Java process). Fixes vaadin/spring#494
caalador
pushed a commit
that referenced
this pull request
Sep 24, 2019
…#6528) Try to reconnect always on connection close. So the process is terminated only if there is a connection error (which happens if there is no network port available which is listen by Java process). Fixes vaadin/spring#494
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to reconnect always on connection close. So the process is
terminated only if there is a connection error (which happens if there
is no network port available which is listen by Java process).
Fixes vaadin/spring#494
This change is