CCDM: generate undefined instead of null #6837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
project-bot
bot
added this to External Reviews
in OLD Vaadin Flow ongoing work (Vaadin 10+)
caalador
removed this from External Reviews
in OLD Vaadin Flow ongoing work (Vaadin 10+)
platosha
force-pushed
the
ap/ccdm/explicit-nullables
branch
4 times, most recently
from
08e622e
to
74af0ff
Compare
qtdzz
force-pushed
the
tn/ccdm/undefined-instead-of-null
branch
from
60b03f0
to
53d258f
Compare
qtdzz
force-pushed
the
tn/ccdm/undefined-instead-of-null
branch
from
53d258f
to
0a6499d
Compare
qtdzz
force-pushed
the
tn/ccdm/undefined-instead-of-null
branch
from
4c282c0
to
aad7f54
Compare
platosha
changed the title
qtdzz
pushed a commit
that referenced
this pull request
Nov 7, 2019
* Use require for request and schema but nullable for response * generate optional parameter and return type * Modify nullable type checker * Add nullIfUndefined helper * Add echo service * Add IT for optional paramter * Fix unit tests nullable * Fix required schema * Clean up * Move nullForUndefined to connect client * Remove null check getting value from TS * Fix unit test in task generator * Fix sonarqube issue * Add nullable test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on the explicit nullable PR. It adds the feature that
@nullableandOptionalwill produce| undefinedreturn type or optional (?) parameter and property.This change is