Prevent npm --version from querying the internets for updates #6860
Conversation
project-bot
bot
added this to External Reviews
in OLD Vaadin Flow ongoing work (Vaadin 10+)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: 1 unresolved discussion, 0 of 1 LGTMs obtained (waiting on @caalador and @denis-anisimov)
flow-server/src/main/java/com/vaadin/flow/server/frontend/FrontendUtils.java, line 593 at r1 (raw file):
npmVersionCommand.add("--version"); FrontendVersion npmVersion = getVersion("npm", npmVersionCommand, Collections.singletonMap("NO_UPDATE_NOTIFIER", "1"));
Shout this env var be set every time for npm call ?
What kind of updates it searches for ?
Update itself or module updates.
It looks like in the first case we should aways use it
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, 0 of 1 LGTMs obtained (waiting on @denis-anisimov)
flow-server/src/main/java/com/vaadin/flow/server/frontend/FrontendUtils.java, line 593 at r1 (raw file):
Previously, denis-anisimov (Denis) wrote…
Shout this env var be set every time for
npmcall ?
What kind of updates it searches for ?
Update itself or module updates.
It looks like in the first case we should aways use it
Instead of adding a environment variable npm should only use the command argument --no-update-notifier
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, 0 of 1 LGTMs obtained (waiting on @denis-anisimov)
flow-server/src/main/java/com/vaadin/flow/server/frontend/FrontendUtils.java, line 593 at r1 (raw file):
Previously, caalador wrote…
Instead of adding a environment variable npm should only use the command argument
--no-update-notifier
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status: 1 unresolved discussion, 0 of 1 LGTMs obtained (waiting on @denis-anisimov)
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, 1 of 1 LGTMs obtained (waiting on @denis-anisimov)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3.
Reviewable status: 1 unresolved discussion, 1 of 1 LGTMs obtained (waiting on @denis-anisimov)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r4.
Reviewable status: 1 unresolved discussion, 1 of 1 LGTMs obtained, and 1 stale (waiting on @denis-anisimov)
There was a problem hiding this comment.
Does it fix #6181 ?
Could you please add Fixes #6181 then ?
Reviewed 1 of 1 files at r4, 1 of 1 files at r5.
Reviewable status: all discussions resolved, 0 of 1 LGTMs obtained, and 2 stale
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, 1 of 1 files at r4, 1 of 1 files at r5.
Reviewable status:complete! all discussions resolved, 1 of 1 LGTMs obtained, and 2 stale
* Prevent npm --version from querying the internets for updates (cherry picked from commit 1c98874)
* Prevent npm --version from querying the internets for updates (cherry picked from commit 1c98874)
* Prevent npm --version from querying the internets for updates (cherry picked from commit 1c98874)
* Prevent npm --version from querying the internets for updates (cherry picked from commit 1c98874)
Fixes #6181
This change is