CCDM: check for null in returned Map values from Connect service methods #6921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
project-bot
bot
added this to External Reviews
in OLD Vaadin Flow ongoing work (Vaadin 10+)
platosha
force-pushed
the
ap/ccdm/explicit-nullables-maps
branch
from
00d8e8b
to
4f78da8
Compare
OLD Vaadin Flow ongoing work (Vaadin 10+)
automation
moved this from External Reviews
to Reviewer approved
Nov 12, 2019
manolo
approved these changes
Nov 12, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all discussions resolved, 1 of 1 LGTMs obtained
OLD Vaadin Flow ongoing work (Vaadin 10+)
automation
moved this from Reviewer approved
to Done - pending release
Nov 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to #6717
This change is