Dp/ccdm/support inline bodysize viewport annotations

[ptdatkhtn]

• allow using @Viewport annotation in Appshell class
• add test case to count the amount of meta tag when using or not using @Viewport annotation
  fixes support @ViewPort annotations on an AppShell class #7171

---

This change is 

[claassistantio]

All committers have signed the CLA.

[claassistantio]

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[manolo]

Reviewable status: 2 unresolved discussions, 0 of 1 LGTMs obtained (waiting on @ptdatkhtn)

---

flow-server/src/main/java/com/vaadin/flow/server/startup/VaadinAppShellRegistry.java, line 182 at r1 (raw file):

        });

        getAnnotations(Viewport.class).forEach(viewport -> {

Viewport only should happen once, although compiler would fail when adding multiple annotations I don't know what happens if class is annotated, but also super class

---

flow-tests/test-ccdm/src/main/java/com/vaadin/flow/ccdmtest/AppShell.java, line 10 at r1 (raw file):

@Meta(name = "foo", content = "bar")
@PWA(name = "My App", shortName = "app")
@Viewport(Viewport.DEVICE_DIMENSIONS)

If you add this you need some assertions in the test class for checking that it happens.
See IndexHtmlRequestHandlerIT.indexHtmlRequestListener_openRootURL_shouldDynamicMetaContent

[ptdatkhtn]

---

flow-tests/test-ccdm/src/main/java/com/vaadin/flow/ccdmtest/AppShell.java, line 10 at r1 (raw file):

Previously, manolo (Manuel Carrasco Moñino) wrote…

If you add this you need some assertions in the test class for checking that it happens.
See IndexHtmlRequestHandlerIT.indexHtmlRequestListener_openRootURL_shouldDynamicMetaContent

Done.

[ptdatkhtn]

---

flow-server/src/main/java/com/vaadin/flow/server/startup/VaadinAppShellRegistry.java, line 182 at r1 (raw file):

Previously, manolo (Manuel Carrasco Moñino) wrote…

Viewport only should happen once, although compiler would fail when adding multiple annotations I don't know what happens if class is annotated, but also super class

Done.

[ptdatkhtn]

---

flow-server/src/main/java/com/vaadin/flow/server/startup/VaadinAppShellRegistry.java, line 188 at r2 (raw file):

Previously, vaadin-bot (Vaadin Bot) wrote…

Use isEmpty() to check whether the collection is empty or not.

Done.

[vaadin-bot]

SonarQube analysis reported 1 issue

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

1. VaadinAppShellInitializer.java#L85: Refactor this method to reduce its Cognitive Complexity from 17 to the 15 allowed.

[manolo]

Reviewed 3 of 5 files at r1, 2 of 3 files at r2, 1 of 1 files at r3.
Reviewable status: 1 unresolved discussion, 1 of 1 LGTMs obtained (waiting on @vaadin-bot)

[manolo]

Reviewable status: 1 unresolved discussion, 1 of 1 LGTMs obtained (waiting on @vaadin-bot)

[manolo]

Dismissed @vaadin-bot from a discussion.
Reviewable status: complete! all discussions resolved, 1 of 1 LGTMs obtained