New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dp/ccdm/bodysize annotation #7179
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 unresolved discussion, 0 of 1 LGTMs obtained (waiting on @ptdatkhtn)
flow-server/src/main/java/com/vaadin/flow/server/startup/VaadinAppShellRegistry.java, line 176 at r2 (raw file):
* Modifies the `index.html` document based on the {@link VaadinAppShell} * annotations. *g
remove
flow-server/src/main/java/com/vaadin/flow/server/startup/VaadinAppShellRegistry.java, line 176 at r2 (raw file): Previously, manolo (Manuel Carrasco Moñino) wrote…
Done. |
…ount amount of style element and check content
0526c4e
to
6c96fe2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 7 files at r3.
Reviewable status: 1 unresolved discussion, 1 of 1 LGTMs obtained (waiting on @manolo)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all discussions resolved, 2 of 1 LGTMs obtained
@BodySize
annotation in AppShell class@BodySize
annotationfixes support @BodySize annotation on an AppShell class #7178
This change is