Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dp/ccdm/bodysize annotation #7179

Merged
merged 4 commits into from Dec 17, 2019
Merged

Dp/ccdm/bodysize annotation #7179

merged 4 commits into from Dec 17, 2019

Conversation

ptdatkhtn
Copy link
Contributor

@ptdatkhtn ptdatkhtn commented Dec 16, 2019


This change is Reviewable

@ptdatkhtn ptdatkhtn added the hilla Issues related to Hilla label Dec 16, 2019
@ptdatkhtn ptdatkhtn self-assigned this Dec 16, 2019
@claassistantio
Copy link

claassistantio commented Dec 16, 2019

CLA assistant check
All committers have signed the CLA.

@claassistantio
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@manolo manolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 unresolved discussion, 0 of 1 LGTMs obtained (waiting on @ptdatkhtn)


flow-server/src/main/java/com/vaadin/flow/server/startup/VaadinAppShellRegistry.java, line 176 at r2 (raw file):

     * Modifies the `index.html` document based on the {@link VaadinAppShell}
     * annotations.
     *g

remove

@ptdatkhtn
Copy link
Contributor Author


flow-server/src/main/java/com/vaadin/flow/server/startup/VaadinAppShellRegistry.java, line 176 at r2 (raw file):

Previously, manolo (Manuel Carrasco Moñino) wrote…

remove

Done.

Copy link
Contributor

@platosha platosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r3.
Reviewable status: 1 unresolved discussion, 1 of 1 LGTMs obtained (waiting on @manolo)

Copy link
Member

@manolo manolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all discussions resolved, 2 of 1 LGTMs obtained

@manolo manolo merged commit 3b4a905 into ccdm Dec 17, 2019
@manolo manolo deleted the dp/ccdm/bodysize-annotation branch December 17, 2019 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hilla Issues related to Hilla +0.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants