CCDM: allow @PageTitle to be in app-shell and views #7266
Conversation
project-bot
bot
added this to External Reviews
in OLD Vaadin Flow ongoing work (Vaadin 10+)
manolo
force-pushed
the
mcm/ccdm/fix-page-title
branch
from
3ddd707
to
07c16de
Compare
There was a problem hiding this comment.
What will happen if there is a @PageTitle annotation on AppShell? Will it override other @PageTitles or others will override the one on AppShell?
Reviewable status: all discussions resolved, 0 of 1 LGTMs obtained (waiting on @haijian-vaadin, @ptdatkhtn, and @vlukashov)
There was a problem hiding this comment.
FYI:
When placed on the app shell class this annotation controls the title returned in the index.html response.
When placed on a route this annotation controls the title set dynamically when the route loads.
In practice, if there are different @PageRoute annotations on the app shell and on the currently rendered route, the browser would initially display the title from the app shell but then quickly switch to the title from the route. In most cases that should be barely noticeable for end users.
Reviewable status: all discussions resolved, 0 of 1 LGTMs obtained (waiting on @ptdatkhtn and @vlukashov)
There was a problem hiding this comment.
Reviewable status:
complete! all discussions resolved, 1 of 1 LGTMs obtained (waiting on @ptdatkhtn and @vlukashov)
This change is