Add close error prompt feature #7467
Conversation
Add feature dropped during merge? Fixes #7211
project-bot
bot
added this to External Reviews
in OLD Vaadin Flow ongoing work (Vaadin 10+)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all discussions resolved, 1 of 1 LGTMs obtained
caalador
moved this from Changes Requested
to External Reviews
in OLD Vaadin Flow ongoing work (Vaadin 10+)
pleku
moved this from External Reviews
to Iteration Reviews
in OLD Vaadin Flow ongoing work (Vaadin 10+)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:
There was a problem hiding this comment.
Not sure if this should have had its own IT which could have prevented the regression ...
Reviewable status:
There was a problem hiding this comment.
An IT just has the problem of how do you get a webpack exception. The current JUnit test is sort of ok, even if a tad heavy on the magical configuration.
Reviewable status:
pleku
moved this from Done - pending release
to Released
in OLD Vaadin Flow ongoing work (Vaadin 10+)
Add feature dropped during merge?
Fixes #7211
This change is