Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove webpack-babel-multi-target-plugin #7475

Merged
merged 1 commit into from
Feb 3, 2020

Conversation

ptdatkhtn
Copy link
Contributor

@ptdatkhtn ptdatkhtn commented Feb 3, 2020

remove webpack-babel-multi-target-plugin
fixes #7409


This change is Reviewable

@ptdatkhtn ptdatkhtn self-assigned this Feb 3, 2020
@project-bot project-bot bot added this to External Reviews in OLD Vaadin Flow ongoing work (Vaadin 10+) Feb 3, 2020
@ptdatkhtn ptdatkhtn added the hilla Issues related to Hilla label Feb 3, 2020
Copy link
Contributor

@platosha platosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all discussions resolved, 1 of 1 LGTMs obtained (waiting on @haijian-vaadin and @manolo)

OLD Vaadin Flow ongoing work (Vaadin 10+) automation moved this from External Reviews to Reviewer approved Feb 3, 2020
@ptdatkhtn ptdatkhtn merged commit 65b43f3 into master Feb 3, 2020
OLD Vaadin Flow ongoing work (Vaadin 10+) automation moved this from Reviewer approved to Done - pending release Feb 3, 2020
@ptdatkhtn ptdatkhtn deleted the remove-webpack-babel-multi-plugin branch February 3, 2020 14:25
@pleku pleku moved this from Done - pending release to Released in OLD Vaadin Flow ongoing work (Vaadin 10+) Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hilla Issues related to Hilla +0.0.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CCDM: use babel/preset-modules instead of webpack-babel-multi-target-plugin
3 participants