CCDM: make IndexHtmlHandler serve any request, execute it the last #7508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
project-bot
bot
added this to External Reviews
in OLD Vaadin Flow ongoing work (Vaadin 10+)
manolo
force-pushed
the
mcm/master/fix-dot-routes
branch
from
29cfcdc
to
d5fc134
Compare
caalador
removed this from External Reviews
in OLD Vaadin Flow ongoing work (Vaadin 10+)
manolo
force-pushed
the
mcm/master/fix-dot-routes
branch
2 times, most recently
from
d62f3b2
to
f83c7b9
Compare
manolo
force-pushed
the
mcm/master/fix-dot-routes
branch
2 times, most recently
from
dd4877c
to
edff250
Compare
manolo
force-pushed
the
mcm/master/fix-dot-routes
branch
from
edff250
to
ec1f1fe
Compare
manolo
force-pushed
the
mcm/master/fix-dot-routes
branch
from
9600888
to
92abf4e
Compare
manolo
force-pushed
the
mcm/master/fix-dot-routes
branch
from
92abf4e
to
7344b37
Compare
haijian-vaadin
approved these changes
Feb 7, 2020
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1.
Reviewable status: all discussions resolved, 0 of 1 LGTMs obtained (waiting on @ptdatkhtn)
haijian-vaadin
approved these changes
Feb 7, 2020
There was a problem hiding this comment.
Reviewable status:
complete! all discussions resolved, 1 of 1 LGTMs obtained (waiting on @ptdatkhtn)
jm-ferreira
pushed a commit
that referenced
this pull request
Feb 7, 2020
…7508) * CCDM: make IndexHtmlHandler serve any request, but put it the la position * CCDM: allow configuring request handled by IndexHtmlHandler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is