Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log: fix duplicated and erroneous message when starting webpack #7524

Merged
merged 1 commit into from
Feb 7, 2020
Merged

log: fix duplicated and erroneous message when starting webpack #7524

merged 1 commit into from
Feb 7, 2020

Conversation

manolo
Copy link
Member

@manolo manolo commented Feb 7, 2020 •
edited by mehdi-vaadin

Probably due to some merging problem, there were duplicated lines in console with erroneous startup timing

----------------- Frontend compiled successfully. -----------------

[main] INFO com.vaadin.flow.server.DevModeHandler - Started webpack-dev-server. Time: 5333ms
[main] INFO com.vaadin.flow.server.DevModeHandler - Webpack startup and compilation completed in -220220958899508ms

This change is Reviewable

@manolo manolo added the hilla Issues related to Hilla label Feb 7, 2020
@manolo manolo self-assigned this Feb 7, 2020
ptdatkhtn
ptdatkhtn approved these changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@ptdatkhtn ptdatkhtn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all discussions resolved, 1 of 1 LGTMs obtained (waiting on @haiwan and @ptdatkhtn)

@ptdatkhtn ptdatkhtn merged commit fc4900e into master Feb 7, 2020
@ptdatkhtn ptdatkhtn deleted the mcm/master/fix-webpack-log branch February 7, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptdatkhtn ptdatkhtn ptdatkhtn approved these changes

@haiwan haiwan Awaiting requested review from haiwan

Assignees

@manolo manolo

Labels
hilla Issues related to Hilla +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@manolo @ptdatkhtn @vaadin-bot