Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update jackson version to avoid failures with spring #7529

Merged
merged 1 commit into from
Feb 10, 2020

Conversation

manolo
Copy link
Member

@manolo manolo commented Feb 10, 2020

Spring version used in vaadin-spring depends on a higher version of jackson
This is needed in order to fix spring tests in MPR.


This change is Reviewable

@manolo manolo added the hilla Issues related to Hilla label Feb 10, 2020
@manolo manolo self-assigned this Feb 10, 2020
Copy link
Contributor

@platosha platosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: all discussions resolved, 0 of 1 LGTMs obtained (waiting on @haijian-vaadin and @ptdatkhtn)

Copy link
Contributor

@ptdatkhtn ptdatkhtn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all discussions resolved, 1 of 1 LGTMs obtained (waiting on @haijian-vaadin and @ptdatkhtn)

@ptdatkhtn ptdatkhtn merged commit 668087b into master Feb 10, 2020
Copy link
Contributor

@platosha platosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all discussions resolved, 2 of 1 LGTMs obtained (waiting on @haijian-vaadin and @ptdatkhtn)

@ptdatkhtn ptdatkhtn deleted the mcm/master/update-jackson branch February 10, 2020 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hilla Issues related to Hilla +1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants