Implement resynchronization of the client and server #7631
Merged
+263
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
project-bot
bot
added this to External Reviews
in OLD Vaadin Flow ongoing work (Vaadin 10+)
joheriks
force-pushed
the
issues/fix-7590
branch
from
818f3e6
to
36f5584
Compare
caalador
previously approved these changes
Feb 20, 2020
There was a problem hiding this comment.
Reviewed 3 of 7 files at r1, 8 of 8 files at r2.
Reviewable status:complete! all discussions resolved, 1 of 1 LGTMs obtained
OLD Vaadin Flow ongoing work (Vaadin 10+)
automation
moved this from External Reviews
to Reviewer approved
Feb 20, 2020
OLD Vaadin Flow ongoing work (Vaadin 10+)
automation
moved this from Reviewer approved
to Changes Requested
Feb 20, 2020
joheriks
commented
Feb 20, 2020
There was a problem hiding this comment.
@Legioth highlighted another potential issue with @ClientCallable promises left hanging on the client-side after the resynchronization. Added a commit to reject them during resynchronization and an IT.
Reviewable status: all discussions resolved, 0 of 1 LGTMs obtained, and 1 stale (waiting on @caalador)
caalador
approved these changes
Feb 21, 2020
There was a problem hiding this comment.
Reviewed 4 of 4 files at r3.
Reviewable status:
OLD Vaadin Flow ongoing work (Vaadin 10+)
automation
moved this from Changes Requested
to Reviewer approved
Feb 21, 2020
OLD Vaadin Flow ongoing work (Vaadin 10+)
automation
moved this from Reviewer approved
to Done - pending release
Feb 21, 2020
joheriks
pushed a commit
that referenced
this pull request
Feb 24, 2020
* Mark server-side state tree unattached and send all changes, clear client-side state tree and rebuild DOM * Reject any pending promises from @ClientCallable invocations during client resynchronization
joheriks
pushed a commit
that referenced
this pull request
Feb 25, 2020
* Mark server-side state tree unattached and send all changes, clear client-side state tree and rebuild DOM * Reject any pending promises from @ClientCallable invocations during client resynchronization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the server receives the resync request, run detach listeners and mark all state tree nodes as not attached. Handle the changes rebuilding the state tree from the root on the client.
Fixes #7590.
This change is