Instantiate UI Instance with Instantiator class (#7446) #7650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
project-bot
bot
added this to External Reviews
in OLD Vaadin Flow ongoing work (Vaadin 10+)
jhult
force-pushed
the
7446-ui-instantiator
branch
from
5d3efda
to
09b04bb
Compare
Update MockInstantiator
jhult
force-pushed
the
7446-ui-instantiator
branch
from
09b04bb
to
648925a
Compare
|
@Legioth, @denis-anisimov, @pleku, Any further thoughts on this? I know it won't help with #6395 but it does resolve #7446. |
pleku
moved this from External Reviews
to Iteration Reviews
in OLD Vaadin Flow ongoing work (Vaadin 10+)
|
Sorry for not taking action on this PR for so long time. As it is discussed in the issue, this not so straight forward to decide what to do with this, but I admin that it is a bad excuse. We discussed this now and we agreed that we don't want to instantiate the UI with the instantiator at the moment. The issue itself #7446 would want to make it easier to use a custom UI for certain things, but we intentionally don't want people to use custom UIs as it brings a set of other problems. We'd rather want to have solution for those cases by other means. Thus closing the PR. |
OLD Vaadin Flow ongoing work (Vaadin 10+)
automation
moved this from Iteration Reviews
to Done - pending release
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instantiating a UI instance can now occur via the Instantiator class.
This change is