Add registration creation shorthands (#7383) #7698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 7f803f9)
|
SonarQube analysis reported 3 issues Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
pleku
added this to External Reviews
in OLD Vaadin Flow ongoing work (Vaadin 10+)
via automation
pleku
approved these changes
Feb 27, 2020
There was a problem hiding this comment.
Reviewed 12 of 12 files at r1.
Reviewable status:complete! all discussions resolved, 1 of 1 LGTMs obtained
OLD Vaadin Flow ongoing work (Vaadin 10+)
automation
moved this from External Reviews
to Reviewer approved
Feb 27, 2020
OLD Vaadin Flow ongoing work (Vaadin 10+)
automation
moved this from Reviewer approved
to Done - pending release
Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 7f803f9)
This change is