Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added servlet parameter maxMessageSuspendTimeout (#7706) #7718

Merged
merged 1 commit into from
Mar 2, 2020

Conversation

joheriks
Copy link
Contributor

@joheriks joheriks commented Feb 28, 2020

This servlet parameter allows tuning the maximum time the client waits for receiving missing messages when it has received an out-of-order message before resynchronizing from the server.


This change is Reviewable

This servlet parameter allows tuning the maximum time the client waits for receiving missing messages when it has received an out-of-order message before resynchronizing from the server.
@joheriks joheriks force-pushed the cp/7658-max-suspend-timeout-parameter-2.1 branch from 49c9033 to fb16244 Compare February 28, 2020 14:39
@joheriks joheriks added this to External Reviews in OLD Vaadin Flow ongoing work (Vaadin 10+) via automation Feb 28, 2020
@joheriks joheriks moved this from External Reviews to Iteration Reviews in OLD Vaadin Flow ongoing work (Vaadin 10+) Feb 28, 2020
@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 9 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL BootstrapHandler.java#L119: Define a constant instead of duplicating this literal "//<![CDATA[\n" 3 times. rule
  2. CRITICAL BootstrapHandler.java#L120: Define a constant instead of duplicating this literal "//]]>" 3 times. rule
  3. MINOR DeploymentConfiguration.java#L68: Remove this use of "isBowerMode"; it is deprecated. rule
  4. MINOR DefaultDeploymentConfiguration.java#L273: Remove this use of "SERVLET_PARAMETER_BOWER_MODE"; it is deprecated. rule
  5. MINOR DefaultDeploymentConfiguration.java#L276: Remove this use of "SERVLET_PARAMETER_BOWER_MODE"; it is deprecated. rule
  6. MINOR PropertyDeploymentConfiguration.java#L153: Remove this use of "SERVLET_PARAMETER_BOWER_MODE"; it is deprecated. rule
  7. MINOR PropertyDeploymentConfiguration.java#L158: Remove this use of "SERVLET_PARAMETER_BOWER_MODE"; it is deprecated. rule
  8. INFO DeploymentConfiguration.java#L58: Do not forget to remove this deprecated code someday. rule
  9. INFO Constants.java#L51: Do not forget to remove this deprecated code someday. rule

OLD Vaadin Flow ongoing work (Vaadin 10+) automation moved this from Iteration Reviews to Reviewer approved Mar 2, 2020
Copy link
Contributor

@mehdi-vaadin mehdi-vaadin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 13 of 13 files at r1.
Reviewable status: :shipit: complete! all discussions resolved, 1 of 1 LGTMs obtained

@mehdi-vaadin mehdi-vaadin merged commit 138feed into 2.1 Mar 2, 2020
OLD Vaadin Flow ongoing work (Vaadin 10+) automation moved this from Reviewer approved to Done - pending release Mar 2, 2020
@mehdi-vaadin mehdi-vaadin deleted the cp/7658-max-suspend-timeout-parameter-2.1 branch March 2, 2020 12:41
@jm-ferreira jm-ferreira added this to the 2.1.6 milestone Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
OLD Vaadin Flow ongoing work (Vaadin ...
  
Done - pending release
Development

Successfully merging this pull request may close these issues.

None yet

4 participants