Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output commands using logger with debug level only #7852

Merged
merged 4 commits into from
Mar 24, 2020
Merged

Conversation

denis-anisimov
Copy link
Contributor

@denis-anisimov denis-anisimov commented Mar 20, 2020

Fixes #7764


This change is Reviewable

mshabarov
mshabarov previously approved these changes Mar 20, 2020
@caalador caalador moved this from Iteration Reviews to Reviewer approved in OLD Vaadin Flow ongoing work (Vaadin 10+) Mar 23, 2020
Copy link
Contributor

@pleku pleku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: 1 unresolved discussion, 0 of 1 LGTMs obtained (waiting on @denis-anisimov)

a discussion (no related file):
What about the commands that install pnpm and run pnpm install ?


OLD Vaadin Flow ongoing work (Vaadin 10+) automation moved this from Reviewer approved to Changes Requested Mar 24, 2020
Copy link
Contributor Author

@denis-anisimov denis-anisimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 unresolved discussion, 0 of 1 LGTMs obtained (waiting on @pleku)

a discussion (no related file):

Previously, pleku (Pekka Hyvönen) wrote…

What about the commands that install pnpm and run pnpm install ?

pnpm install : yes, forgot to update FrontendTools::installPnpm . Done.

Run pnpm(npm) : already done in the TaskRunNpmInstall .


@vaadin-bot vaadin-bot added +1.0.0 and removed +0.0.1 labels Mar 24, 2020
OLD Vaadin Flow ongoing work (Vaadin 10+) automation moved this from Changes Requested to Reviewer approved Mar 24, 2020
Copy link
Contributor

@pleku pleku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r2.
Reviewable status: :shipit: complete! all discussions resolved, 1 of 1 LGTMs obtained

@pleku pleku merged commit b358d29 into master Mar 24, 2020
OLD Vaadin Flow ongoing work (Vaadin 10+) automation moved this from Reviewer approved to Done - pending release Mar 24, 2020
@pleku pleku deleted the 7764-extra-logging branch March 24, 2020 16:48
pleku pushed a commit that referenced this pull request Apr 2, 2020
pleku pushed a commit that referenced this pull request Apr 2, 2020
pleku pushed a commit that referenced this pull request Apr 2, 2020
pleku pushed a commit that referenced this pull request Apr 2, 2020
pleku pushed a commit that referenced this pull request Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
OLD Vaadin Flow ongoing work (Vaadin ...
  
Done - pending release
Development

Successfully merging this pull request may close these issues.

Remove logging for Node.js commands and pnpm installing & running
4 participants