Be aware of skinny war workaround in OSGi support #8110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaadin-bot
reviewed
Apr 20, 2020
| // don't use onStartup method because a fake servlet context is | ||
| // passed here: no need to detect classloaders in OSGi case | ||
| ((ClassLoaderAwareServletContainerInitializer) initializer).process( | ||
| filterClasses(handleTypes.orElse(null)), | ||
| getOsgiServletContext()); | ||
| } catch (ServletException e) { | ||
| throw new RuntimeException( |
There was a problem hiding this comment.
|
SonarQube analysis reported 5 issues
Watch the comments in this conversation to review them. 4 extra issuesNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
caalador
approved these changes
Apr 21, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Dismissed @vaadin-bot from a discussion.
Reviewable status:complete! all discussions resolved, 1 of 1 LGTMs obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should have been fixed initially in
2.2branch but2.2has no any OSGi support for different reason (see #8109). So it can't be tested there.Fixes #8105
This change is