Be aware of skinny war workaround in OSGi support #8111
Conversation
| // don't use onStartup method because a fake servlet context is | ||
| // passed here: no need to detect classloaders in OSGi case | ||
| ((ClassLoaderAwareServletContainerInitializer) initializer).process( | ||
| filterClasses(handleTypes.orElse(null)), | ||
| getOsgiServletContext()); | ||
| } catch (ServletException e) { | ||
| throw new RuntimeException( |
There was a problem hiding this comment.
There was a problem hiding this comment.
Reviewable status: 2 unresolved discussions, 0 of 1 LGTMs obtained (waiting on @denis-anisimov)
a discussion (no related file):
This is not the whole story.
2.2 doesn't support OSGi for many various reasons
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Dismissed @vaadin-bot from a discussion.
Reviewable status: 1 unresolved discussion, 0 of 1 LGTMs obtained (waiting on @denis-anisimov)
a discussion (no related file):
Previously, denis-anisimov (Denis) wrote…
This is not the whole story.
2.2doesn't support OSGi for many various reasons
Seems like using
<dependency>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpclient-osgi</artifactId>
<version>4.5.12</version>
</dependency>
Poses no problems for the downloader and can be used as is.
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, 0 of 1 LGTMs obtained (waiting on @caalador)
a discussion (no related file):
Previously, caalador wrote…
Seems like using
<dependency> <groupId>org.apache.httpcomponents</groupId> <artifactId>httpclient-osgi</artifactId> <version>4.5.12</version> </dependency>Poses no problems for the downloader and can be used as is.
Unfortunately it's not enough.
There was a problem hiding this comment.
ready for review
Reviewable status: all discussions resolved, 0 of 1 LGTMs obtained
|
SonarQube analysis reported 6 issues
Watch the comments in this conversation to review them. 5 extra issuesNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
caalador
added this to Iteration Reviews
in OLD Vaadin Flow ongoing work (Vaadin 10+)
via automation
There was a problem hiding this comment.
Reviewed 5 of 5 files at r2.
Reviewable status:complete! all discussions resolved, 1 of 1 LGTMs obtained
Was not tested in
2.2because OSGi is completely broken (#8109).Fixes #8105
This change is