Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw an exception which provides an info about vetoed property change #8530

Merged
merged 3 commits into from
Jun 15, 2020
Merged

Throw an exception which provides an info about vetoed property change #8530

merged 3 commits into from
Jun 15, 2020

Conversation

denis-anisimov
Copy link
Contributor

Fixes #3470

@denis-anisimov denis-anisimov added this to Iteration Reviews in OLD Vaadin Flow ongoing work (Vaadin 10+) via automation Jun 9, 2020
@pleku pleku self-requested a review June 11, 2020 06:08
denis-anisimov
denis-anisimov commented Jun 11, 2020
View reviewed changes
Copy link
Contributor Author

@denis-anisimov denis-anisimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pleku
pleku previously approved these changes Jun 11, 2020
View reviewed changes
@pleku
Copy link
Contributor

pleku commented Jun 11, 2020

Tests not refactored with new exception name ?

@denis-anisimov
Copy link
Contributor Author

Tests not refactored with new exception name ?

Yes, Eclipse works with Flow project worse every time....

@denis-anisimov denis-anisimov force-pushed the 3470-report-disallowed-property branch from 345ccd6 to a06453b Compare June 12, 2020 05:13
@denis-anisimov denis-anisimov merged commit 9b11089 into master Jun 15, 2020
OLD Vaadin Flow ongoing work (Vaadin 10+) automation moved this from Iteration Reviews to Done - pending release Jun 15, 2020
@denis-anisimov denis-anisimov deleted the 3470-report-disallowed-property branch June 15, 2020 08:13
@pleku
Copy link
Contributor

pleku commented Jun 15, 2020

As the bot is right and this adds new code -> fix is only to be cherry picked to 2.4 once we start building that. Otherwise it can stay just master.

pleku pushed a commit that referenced this pull request Sep 8, 2020
@pleku
Throw an exception which provides an info about vetoed property change (
b88735b 
#8530)

Fixes #3470
mshabarov pushed a commit that referenced this pull request Sep 17, 2020
@mshabarov
Throw an exception which provides an info about vetoed property change (
490024d 
#8530)

Fixes #3470
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleku pleku pleku approved these changes

Assignees
No one assigned
Labels
+0.1.0
Projects
OLD Vaadin Flow ongoing work (Vaadin ...
  
Done - pending release
Milestone
No milestone
3 participants
@denis-anisimov @pleku @vaadin-bot