Fix priority order of npmrc files #8701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I assume the order of things on this method define the priority. As Proxy and ProxyConfig doesn't have any priority logic. If/when that's the case the order is wrong. Project file should have higher priority than User file. https://docs.npmjs.com/configuring-npm/npmrc.html
|
SonarQube analysis reported 1 issue Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
|
SonarQube warning/error isn't related to lines I changed. |
joheriks
approved these changes
Jul 8, 2020
mshabarov
pushed a commit
that referenced
this pull request
Jul 9, 2020
Project file should have higher priority than User file: https://docs.npmjs.com/configuring-npm/npmrc.html (cherry picked from commit 6806b8a)
Merged
joheriks
pushed a commit
that referenced
this pull request
Jul 13, 2020
Project file should have higher priority than User file: https://docs.npmjs.com/configuring-npm/npmrc.html (cherry picked from commit 6806b8a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I assume the order of things on this method define the priority. As Proxy and ProxyConfig doesn't have any priority logic.
If/when that's the case the order is wrong. Project file should have higher priority than User file.
https://docs.npmjs.com/configuring-npm/npmrc.html