Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize string before removing comments from it. #8792

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

denis-anisimov
Copy link
Contributor

Fixes #8713

@denis-anisimov denis-anisimov added this to Iteration Reviews in OLD Vaadin Flow ongoing work (Vaadin 10+) via automation Jul 29, 2020
@mshabarov mshabarov merged commit 1311500 into master Jul 29, 2020
OLD Vaadin Flow ongoing work (Vaadin 10+) automation moved this from Iteration Reviews to Done - pending release Jul 29, 2020
@mshabarov mshabarov deleted the 8713-emoji-in-template branch July 29, 2020 14:09
@mshabarov mshabarov moved this from Done - pending release to Released in OLD Vaadin Flow ongoing work (Vaadin 10+) Jul 31, 2020
mshabarov pushed a commit that referenced this pull request Aug 11, 2020
mshabarov pushed a commit that referenced this pull request Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emoji in Polymer 3 template blows up SwingUtil.removeComments
3 participants