Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend javadocs for Text and clarify not-supported API #8799

Merged
merged 2 commits into from
Jul 31, 2020

Conversation

denis-anisimov
Copy link
Contributor

Fixes #4882

@denis-anisimov denis-anisimov added this to Iteration Reviews in OLD Vaadin Flow ongoing work (Vaadin 10+) via automation Jul 30, 2020
* @throws UnsupportedOperationException
*/
@Override
public void setId(String id) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MINOR Remove this method to simply inherit it. rule

@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 1 issue

  • MINOR 1 minor

Watch the comments in this conversation to review them.

@denis-anisimov denis-anisimov merged commit a153411 into master Jul 31, 2020
OLD Vaadin Flow ongoing work (Vaadin 10+) automation moved this from Iteration Reviews to Done - pending release Jul 31, 2020
@denis-anisimov denis-anisimov deleted the 4882-text-component branch July 31, 2020 06:25
mshabarov pushed a commit that referenced this pull request Aug 13, 2020
caalador pushed a commit that referenced this pull request Aug 20, 2020
@mshabarov mshabarov mentioned this pull request Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
OLD Vaadin Flow ongoing work (Vaadin ...
  
Done - pending release
Development

Successfully merging this pull request may close these issues.

Text Javadoc could be improved
3 participants