Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert fix for #8729 #8833

Merged
merged 2 commits into from Aug 10, 2020
Merged

Revert fix for #8729 #8833

merged 2 commits into from Aug 10, 2020

Conversation

denis-anisimov
Copy link
Contributor

Something is broken with the PR.
So it's completely removed.

@denis-anisimov denis-anisimov added this to Iteration Reviews in OLD Vaadin Flow ongoing work (Vaadin 10+) via automation Aug 10, 2020
@mshabarov mshabarov merged commit 1b08b7c into 2.3 Aug 10, 2020
OLD Vaadin Flow ongoing work (Vaadin 10+) automation moved this from Iteration Reviews to Done - pending release Aug 10, 2020
@mshabarov mshabarov deleted the live-reload-revert branch August 10, 2020 07:37
@silvan-lincan
Copy link

silvan-lincan commented Aug 12, 2020

Super. This fixes also #8822 , #8825 => no need to disable liveReload when in dev-mode.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
OLD Vaadin Flow ongoing work (Vaadin ...
  
Done - pending release
Development

Successfully merging this pull request may close these issues.

None yet

4 participants