Fix setClassName to work as specified in javadoc #8842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleku
suggested changes
Aug 12, 2020
| @@ -70,6 +70,10 @@ public void removeClassName() { | |||
| component.removeClassName("baz"); | |||
| assertClasses(component); | |||
|
|
|||
| component.setClassName("removeMe"); | |||
| // setting null to classname should remove class name attribute | |||
| component.setClassName(null); | |||
There was a problem hiding this comment.
Missing assert or assertClasses ?
Technically I would have expected test to go to the setClassName() method below
There was a problem hiding this comment.
Moved and fixed.
I totally forgot the assert as the unfixed fails already on set before the assert.
Added missing assert.
pleku
approved these changes
Aug 12, 2020
OLD Vaadin Flow ongoing work (Vaadin 10+)
automation
moved this from Iteration Reviews
to Done - pending release
Aug 12, 2020
caalador
added a commit
that referenced
this pull request
Aug 12, 2020
caalador
added a commit
that referenced
this pull request
Aug 12, 2020
mshabarov
pushed a commit
that referenced
this pull request
Aug 13, 2020
caalador
added a commit
that referenced
this pull request
Aug 20, 2020
Merged
haijian-vaadin
pushed a commit
that referenced
this pull request
Aug 24, 2020
mshabarov
pushed a commit
that referenced
this pull request
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8840