feat(TypeScript): support form binding with optional fields and objects #8847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
platosha
force-pushed
the
ap/feature/forms/null-object-combo-box
branch
from
047cfbc
to
badae56
Compare
platosha
changed the title
platosha
changed the title
platosha
force-pushed
the
ap/feature/forms/null-object-combo-box
branch
from
badae56
to
0958de4
Compare
platosha
force-pushed
the
ap/feature/forms/null-object-combo-box
branch
from
0958de4
to
4a4e44b
Compare
platosha
force-pushed
the
ap/feature/forms/null-object-combo-box
branch
from
4a4e44b
to
e4f14b3
Compare
platosha
force-pushed
the
ap/feature/forms/null-object-combo-box
branch
from
e4f14b3
to
f4792dd
Compare
Haprog
previously approved these changes
Aug 14, 2020
BREAKING CHANGE: TypeScript the `value` property of `BinderNode` now has
optionally `undefined` type for non-initialised optional fields.
In terms of forms, an object field could be used in both ways: as
an individual field or a grouping for the object’s nested fields.
Previously, the optional fields in empty form value objects were initialised
by the client-side binder with a generated value when `BinderNode` or
form binding is created for such fields. Such a behavior works well with
grouping object fields, but makes it problematic to bind an individual
optional field of object type by making empty value already defined.
With this change, the client-side form binder skips initialising
optional fields, keeping their values `undefined`, unless there is
a binding for a nested field inside an optional parent object.
For example: with a binding for `model.optionalObject` will have
a corresponding empty form value of `{"optionalObject": undefined}`,
however, with a binding of `model.optionalObject.nestedString`, the
empty form value will contain a generated object: `{"optioanlObject":
{"nestedString": ""}}`.
platosha
force-pushed
the
ap/feature/forms/null-object-combo-box
branch
from
f4792dd
to
f5796e1
Compare
haijian-vaadin
approved these changes
Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: TypeScript the
valueproperty ofBinderNodenow has optionallyundefinedtype for non-initialised optional fields.In terms of forms, an object field could be used in both ways: as an individual field or a grouping for the object’s nested fields.
Previously, the optional fields in empty form value objects were initialised by the client-side binder with a generated value when a
BinderNode(or a form binding) is created for such fields. Such a behavior works well with grouping object fields, but makes it problematic to bind an individual optional field of object type by making empty value already defined.With this change, the client-side form binder skips initialising optional fields, keeping their values
undefined, unless there is a binding for a nested field inside an optional parent object.For example: with a binding for
model.optionalObjectwill have a corresponding empty form value of{"optionalObject": undefined}, however, with a binding ofmodel.optionalObject.nestedString, the empty form value will contain a generated object:{"optioanlObject": {"nestedString": ""}}.