Live reload on frontend changes #8875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joheriks
force-pushed
the
joheriks/webpack-live-reload
branch
4 times, most recently
from
8eab654
to
bb3ced6
Compare
When the webpack dev server finished recompilation, it notifies the Java server over the watchdog connection. When the server notices the message, it sends a browser reload message over the dedicated live reload web socket connection. Other changes in this commit: - live reload support for V14 bootstrapping mode - vaadin-devmode-gizmo is now bundled separately
joheriks
force-pushed
the
joheriks/webpack-live-reload
branch
from
bb3ced6
to
91209f1
Compare
vaadin-bot
reviewed
Aug 21, 2020
| @@ -72,18 +73,21 @@ | |||
| * name of the JS file to update with the Flow project imports | |||
| * @param useV14Bootstrapping | |||
| * whether the application running with deprecated V14 bootstrapping | |||
| * @param flowResourcesFolder | |||
| * relative path to `flow-frontend` package | |||
| */ | |||
| TaskUpdateWebpack(File frontendDirectory, File webpackConfigFolder, | |||
There was a problem hiding this comment.
added 2 commits
August 21, 2020 12:46
vaadin-bot
reviewed
Aug 21, 2020
| @@ -79,6 +84,19 @@ private Logger getLogger() { | |||
| return LoggerFactory.getLogger(WatchDogServer.class); | |||
| } | |||
|
|
|||
| private void enterReloadMessageReadLoop(Socket accept) throws IOException{ | |||
| BufferedReader in = new BufferedReader(new InputStreamReader(accept.getInputStream())); | |||
There was a problem hiding this comment.
vaadin-bot
reviewed
Aug 21, 2020
| @@ -406,6 +406,12 @@ | |||
| @Deprecated | |||
| public static final String SERVLET_PARAMETER_DEVMODE_ENABLE_LIVE_RELOAD = InitParameters.SERVLET_PARAMETER_DEVMODE_ENABLE_LIVE_RELOAD; | |||
There was a problem hiding this comment.
platosha
previously approved these changes
Aug 21, 2020
caalador
requested changes
Aug 24, 2020
flow-client/src/main/java/com/vaadin/client/ApplicationConfiguration.java
Show resolved
Hide resolved
caalador
previously approved these changes
Aug 24, 2020
caalador
approved these changes
Aug 24, 2020
|
SonarQube analysis reported 34 issues
Watch the comments in this conversation to review them. Top 10 extra issuesNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
OLD Vaadin Flow ongoing work (Vaadin 10+)
automation
moved this from Iteration Reviews
to Done - pending release
Aug 24, 2020
caalador
pushed a commit
that referenced
this pull request
Aug 24, 2020
Trigger live reload when webpack recompiles frontend files When the webpack dev server finished recompilation, it notifies the Java server over the watchdog connection. When the server notices the message, it sends a browser reload message over the dedicated live reload web socket connection. Other changes in this commit: - live reload support for V14 bootstrapping mode - vaadin-devmode-gizmo is now bundled separately - Convert VaadinDevmodeGizmo to TypeScript
pleku
pushed a commit
that referenced
this pull request
Aug 24, 2020
Trigger live reload when webpack recompiles frontend files When the webpack dev server finished recompilation, it notifies the Java server over the watchdog connection. When the server notices the message, it sends a browser reload message over the dedicated live reload web socket connection. Other changes in this commit: - live reload support for V14 bootstrapping mode - vaadin-devmode-gizmo is now bundled separately - Convert VaadinDevmodeGizmo to TypeScript
|
When/if backporting to 2.3, check compatibility with ES5 transpilation (e.g. |
This was referenced Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the webpack dev server finished recompilation, it will notify the Java server over
the watchdog connection. When the Java server notices the message, it in turn sends
the browser reload message over the dedicated live reload web socket connections.
Other changes in this commit:
Addresses tickets #8852, #8721, #8001, #5617, #607 (and maybe others).