Add HasHelper interface #8922
Add HasHelper interface #8922
Conversation
|
|
||
| /** | ||
| * <p> | ||
| * String used for the helper text. |
There was a problem hiding this comment.
One might wonder, "what is helper text" as it is not that universal concept (yet?) compared to e.g. placeholder. At least could be unfamiliar for Java developers. So I think it would be good to add a clarification on "how/when it might be shown on the component"
There was a problem hiding this comment.
And same for setHelperComponent
There was a problem hiding this comment.
Added text describing the feature more for both setters.
| default void setHelperComponent(Component component) { | ||
| getElement().getChildren() | ||
| .filter(child -> "helper".equals(child.getAttribute("slot"))) | ||
| .collect(Collectors.toList()) |
There was a problem hiding this comment.
Unnecessary collecting to a list since it seems like there can only ever be one child with the slot=helper, so could go with findAny().ifPresent(...) instead
| Optional<Element> element = getElement().getChildren() | ||
| .filter(child -> "helper".equals(child.getAttribute("slot"))) | ||
| .findFirst(); | ||
| if (element.isPresent()) { |
There was a problem hiding this comment.
I don't think this is necessary for readability as it adds more lines, could just use mapping to the Stream with map(Element::get) before findFirst() and then return component.orElse(null);.
There was a problem hiding this comment.
I changed as suggested, but then findFirst() returns an Optional<Optional<Component>> object, so I had to add a .orElse(Optional.empty()).
* Add HasHelper interface (#8532)
|
PR to master (5.0) open too. |
* Add HasHelper interface (#8532)
On this PR:
Fix #8871